container-driver: fix volume destination for cache#751
container-driver: fix volume destination for cache#751tonistiigi merged 1 commit intodocker:masterfrom
Conversation
The container-driver creates a Linux container (as there currently isn't a
Windows version of buildkitd). However, the defaults are platform specific.
Buildx was using the defaults from the buildkit `util/appdefault' package,
which resulted in Buildx running on a Windows client to create a Linux
container that used the Windows location, which causes it to fail:
invalid mount config for type "volume": invalid mount path: 'C:/ProgramData/buildkitd/.buildstate' mount path must be absolute
This patch hard-codes the destination to the default Linux path.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
@tonistiigi @crazy-max PTAL |
|
Also wondering if buildx checks if the daemon is running on Linux or Windows (if it's on Windows (native Windows containers) it should not support the container-driver. (or buildkit as a whole, currently) |
|
Hi, Docker 4.0.0 still happening. PS D:> docker buildx create --name mybuilder --use PS D:> docker buildx inspect --bootstrap [internal] booting buildkit: Name: mybuilder Nodes: PS D:> docker -v |
|
@zimbres I don't think buildx 0.6.3 was included in Docker Desktop 4.0.0 yet (it will be included in a future patch release), but you can manually install an updated binary release; https://github.com/docker/buildx#binary-release |
|
@thaJeztah thank you! Its correct, buildx was 0.6.1. Running fine after override the buildx. |
3 participants
fixes #749
The container-driver creates a Linux container (as there currently isn't a
Windows version of buildkitd). However, the defaults are platform specific.
Buildx was using the defaults from the buildkit `util/appdefault' package,
which resulted in Buildx running on a Windows client to create a Linux
container that used the Windows location, which causes it to fail:
This patch hard-codes the destination to the default Linux path.